[NFC] Cleanup typed pointer holdovers in clang-offload-wrapper #19370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldrumm
force-pushed
the
no-typed-ptrs-no-more
branch
from
ad6df41 to
70459b6
Compare
The overload llvm::PointerType::getUnqual(ElementTy *) is now simply a
wrapper around `llvm::PointerType::getUnqual(Context &)` i.e.
PointerType *llvm::PointerType::getUnqual(ElementTy *E) {
return getUnqual(E->getContext());
}
Since there's no longer a possible distinction between the returned
types, we can get rid of all the typed getters and simply cached the
unqualified opaque pointer type on first use.
ldrumm
force-pushed
the
no-typed-ptrs-no-more
branch
from
70459b6 to
f47c8c8
Compare
maksimsab
approved these changes
Jul 15, 2025
ldrumm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overload
llvm::PointerType::getUnqual(ElementTy *)is now simply a wrapper aroundllvm::PointerType::getUnqual(Context &)i.e.(ignoring the attributes that raised the deprecation warning in the first place)
Since there's no longer a possible distinction between the returned types, we can get rid of all the typed getters and simply cache the unqualified opaque pointer type on first use.